TYP: resolve ignored mypy errors in core/describe.py #46928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
May 2, 2022
twoertwein
approved these changes
May 2, 2022
Member
twoertwein
left a comment
twoertwein
left a comment
There was a problem hiding this comment.
Small comment, looks good otherwise!
iasoon
force-pushed
the
typing/core-describe
branch
from
1be8d92 to
60e3879
Compare
twoertwein
reviewed
May 3, 2022
|
|
||
| def format_percentiles( | ||
| percentiles: (np.ndarray | list[int | float] | list[float] | list[str | float]), | ||
| percentiles: (np.ndarray | Sequence[float]), |
Member
There was a problem hiding this comment.
Was there a reason why the function was supposed to accept strings? @jreback I don't think it supports str as one of the first lines isnp.isclose(percentiles.astype(int), percentiles) which should fail for str (didn't try it)?
Contributor
There was a problem hiding this comment.
don't remember. happy to eliminate it (assume we don't have tests / usage for this)
Contributor
|
thanks @iasoon |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715