TYP: CallableDynamicDoc #46786
Merged
TYP: CallableDynamicDoc #46786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-25 23:36:05 UTC |
twoertwein
commented
Apr 15, 2022
pandas/core/indexing.py
Outdated
| return self._handle_lowerdim_multi_index_axis0(tup) | ||
| # error "_LocationIndexer" has no attribute | ||
| # "_handle_lowerdim_multi_index_axis0" | ||
| return self._handle_lowerdim_multi_index_axis0( # type: ignore[attr-defined] |
There was a problem hiding this comment.
I was about to make _LocationIndexer an abstract class but a sub-class (_iLocIndexer) does not implement _handle_lowerdim_multi_index_axis0 even though the class is being instantiated.
There was a problem hiding this comment.
any ideas on how to make flake8&mypy&black accept this line (and the same line later in this file)?
There was a problem hiding this comment.
using a cast to make flake8&mypy&black happy
|
@jbrockmendel Could you have a look at |
jbrockmendel
reviewed
May 8, 2022
jbrockmendel
reviewed
May 8, 2022
jreback
approved these changes
May 8, 2022
mroeschke
approved these changes
May 26, 2022
|
Thanks @twoertwein |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: CallableDynamicDoc * using cast * tighten NDFrameIndexerBase * dtype and clarification for _IndexingMixinT Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more tricky parts of #46698.
Adding type annotations to
CallableDynamicDocseems to uncover multiple missing type annotations. I'm not very confident in some of the new pyi files (types for cython/c functions).