Skip to content

updated head and tail docstrings #46466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2022
Merged

updated head and tail docstrings #46466

merged 2 commits into from
Mar 22, 2022

Conversation

INDIG0N
Copy link
Contributor

@INDIG0N INDIG0N commented Mar 22, 2022

@@ -5284,6 +5284,8 @@ def head(self: NDFrameT, n: int = 5) -> NDFrameT:
For negative values of `n`, this function returns all rows except
the last `n` rows, equivalent to ``df[:-n]``.

If n is larger than the number of rows, this function returns al rows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

al -> all? Same as below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeo, that's a typo, sorry. I'm kinda new at this, am I supposed to make a new pull request after fixing it and this one will be automatically closed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just add another commit fixing this typo to this pull request. When merged, all the commits will be squashed.

# Fix the typo
git add pandas/core/generic.py
git commit -m"Fixed all typo"
git push origin <branch_name>

@INDIG0N
Copy link
Contributor Author

INDIG0N commented Mar 22, 2022

does anybody know why that one check is failing? I can't figure it out.

@mroeschke mroeschke added the Docs label Mar 22, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 22, 2022
@mroeschke mroeschke merged commit f7a9dac into pandas-dev:main Mar 22, 2022
@mroeschke
Copy link
Member

Thanks @INDIG0N the failures were unrelated

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* updated head and tail docstrings

* fixed typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: tail works even if n > length of DataFrame
2 participants