Skip to content

CI: xfail geopandas downstream test on MacOS due to fiona install #46296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2022
Merged

CI: xfail geopandas downstream test on MacOS due to fiona install #46296

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e51b253
CI: xfail geopandas downstream test on MacOS due to fiona install
mroeschke Mar 9, 2022
0d9d3e0
More specific case
mroeschke Mar 9, 2022
6b76852
Just skip generally for mac
mroeschke Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pandas/tests/test_downstream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
import numpy as np
import pytest

from pandas.compat import (
PY39,
PY310,
is_platform_mac,
)
import pandas.util._test_decorators as td

import pandas as pd
Expand Down Expand Up @@ -196,6 +201,13 @@ def test_pandas_datareader():

# importing from pandas, Cython import warning
@pytest.mark.filterwarnings("ignore:can't resolve:ImportWarning")
@pytest.mark.xfail(
is_platform_mac() and (PY39 or PY310),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a failure in python 3.8 test on MacOS as well.

raises=ImportError,
reason="ImportError: the 'read_file' function requires the 'fiona' package, "
"but it is not installed or does not import correctly",
strict=False,
)
def test_geopandas():

geopandas = import_module("geopandas")
Expand Down