Typeinterval part2 #46098
Merged
Typeinterval part2 #46098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Feb 21, 2022
twoertwein
reviewed
Feb 21, 2022
twoertwein
reviewed
Feb 21, 2022
twoertwein
reviewed
Feb 21, 2022
twoertwein
reviewed
Feb 21, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
twoertwein
reviewed
Feb 22, 2022
|
Looks pretty good @Dr-Irv! I'll look at part 1 tomorrow. |
Thanks! |
twoertwein
reviewed
Feb 22, 2022
Closed
|
other PR merged so pls rebase |
all set and all green |
twoertwein
reviewed
Feb 27, 2022
twoertwein
reviewed
Feb 27, 2022
twoertwein
reviewed
Feb 27, 2022
twoertwein
reviewed
Feb 27, 2022
- Use IntervalClosedType - Consolidate __get__ in LengthDescriptor - Use tuple instead of Tuple
twoertwein
approved these changes
Feb 27, 2022
|
thanks @Dr-Irv keep em coming! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is on top of #46080
I believe the typing for
Intervalhere is correct as it passes the tests created here:microsoft/python-type-stubs#167
Leaving this as draft status as it requires #46080 to be approved.
Or a decision to go with #44922, in which case we kill #46080 and this one.