Skip to content

DOC: fix incorrect pie chart documentation #45748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2022
Merged

DOC: fix incorrect pie chart documentation #45748

merged 2 commits into from
Feb 1, 2022

Conversation

partev
Copy link
Contributor

@partev partev commented Feb 1, 2022

in pandas-1.2 we used to get a semicircle. However since pandas-1.3 and later the values get rescaled so that they sum up to 1.
This pull request is updating the documentation to reflect this. It looks like matplotlib still draws a partial circle, so this is a change that was made in pandas.

https://pandas.pydata.org/pandas-docs/version/1.2/user_guide/visualization.html#pie-plot
image

https://pandas.pydata.org/docs/dev/user_guide/visualization.html#visualization-pie
image

@mroeschke
Copy link
Member

Could you merge the main branch one more time?

@partev
Copy link
Contributor Author

partev commented Feb 1, 2022

Could you merge the main branch one more time?

I am not sure how to do it.

@mroeschke mroeschke added this to the 1.5 milestone Feb 1, 2022
@mroeschke mroeschke merged commit 71f5a74 into pandas-dev:main Feb 1, 2022
@mroeschke
Copy link
Member

Thanks @partev

@partev partev deleted the patch-8 branch February 1, 2022 22:34
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants