Skip to content

Revert "PERF: nancorr pearson (#42761)" #45646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2022
Merged

Revert "PERF: nancorr pearson (#42761)" #45646

merged 4 commits into from
Jan 26, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 26, 2022

@phofl phofl added Regression Functionality that used to work in a prior pandas version Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Jan 26, 2022
@phofl phofl added this to the 1.4.1 milestone Jan 26, 2022
mzeitlin11
mzeitlin11 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@mzeitlin11 mzeitlin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing @phofl!

@jreback jreback merged commit b33c630 into pandas-dev:main Jan 26, 2022
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 26, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 26, 2022
@phofl @meeseeksmachine
Backport PR pandas-dev#45646: Revert "PERF: nancorr pearson (pandas-d…
570c8e8 
…ev#42761)"
@jreback
Copy link
Contributor

jreback commented Jan 26, 2022

thanks @phofl

I guess we should re-open the original issue though that was a bit off point.

@phofl
Copy link
Member Author

phofl commented Jan 26, 2022

I think it was not closer back then, just referenced

jreback pushed a commit that referenced this pull request Jan 27, 2022
@meeseeksmachine @phofl
Backport PR #45646: Revert "PERF: nancorr pearson (#42761)" (#45649)
2fcb0cd 
Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the 45640 branch January 28, 2022 10:19
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@phofl @yehoshuadimarsky
Revert "PERF: nancorr pearson (pandas-dev#42761)" (pandas-dev#45646)
1ac7824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mzeitlin11 mzeitlin11 mzeitlin11 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

BUG: REGRESSION: DataFrame.corr() floating point inaccuracy
3 participants
@phofl @jreback @mzeitlin11