Skip to content

Test to datetime null to NaT #45512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 1, 2022
Merged

Test to datetime null to NaT #45512

Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f67ffe3
Testing to_datetime, converting none to NaT
Aug 12, 2021
908c202
Testing to_datetime, converting NA/NaN to NaT
Aug 12, 2021
bfbfb62
Fix linting issues - move test near other related ones.
Aug 20, 2021
ab1851b
Fix CI error: function uses no argument 'cache'
Aug 20, 2021
479a978
Testing to_datetime, converting none to NaT
Aug 12, 2021
b0fe84e
Testing to_datetime, converting NA/NaN to NaT
Aug 12, 2021
a79d754
Fix linting issues - move test near other related ones.
Aug 20, 2021
da9fa35
Fix CI error: function uses no argument 'cache'
Aug 20, 2021
1f41a89
Merge branch 'test_to_datetime_null_to_NaT' of github.com:ryangilmour…
Jan 20, 2022
dadf5fd
reduce test case series sizes
Jan 21, 2022
53335df
ignore list item in type checking
Jan 23, 2022
68ce176
Merge branch 'main' into test_to_datetime_null_to_NaT
Jan 31, 2022
b3862a3
test caching and non-caching behaviour
Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pandas/tests/tools/test_to_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,6 +1066,25 @@ def test_convert_object_to_datetime_with_cache(
)
tm.assert_series_equal(result_series, expected_series)

@pytest.mark.parametrize("cache", [True, False])
@pytest.mark.parametrize(
("input", "expected"),
(
(
Series([NaT] * 200 + [None] * 200, dtype="object"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind using less values here? (20/40 should be good)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a predefined breakpoitn with 50 values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but IIRC that's needed when specifically testing caching behavior

Series([NaT] * 400, dtype="datetime64[ns]"),
),
(Series([None] * 200), Series([NaT] * 200, dtype="datetime64[ns]")),
(Series([""] * 200), Series([NaT] * 200, dtype="datetime64[ns]")),
(Series([pd.NA] * 200), Series([NaT] * 200, dtype="datetime64[ns]")),
(Series([np.NaN] * 200), Series([NaT] * 200, dtype="datetime64[ns]")),
),
)
def test_to_datetime_converts_null_like_to_nat(self, cache, input, expected):
# GH35888
result = to_datetime(input, cache=cache)
tm.assert_series_equal(result, expected)

@pytest.mark.parametrize(
"date, format",
[
Expand Down