Skip to content

Conversation

twoertwein
Copy link
Member

Default values in stub files are not used by type checkers (and they might get out of sync with the implementation).

@twoertwein twoertwein changed the title enable reportInvalidStubStatement CLN: enable reportInvalidStubStatement Sep 28, 2021
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Sep 28, 2021
@jreback jreback added this to the 1.4 milestone Sep 28, 2021
@jreback
Copy link
Contributor

jreback commented Sep 28, 2021

looks fine, can you rebase

@twoertwein
Copy link
Member Author

@jreback rebased & green

@jreback jreback merged commit 010ea17 into pandas-dev:master Sep 28, 2021
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
@twoertwein twoertwein deleted the stub branch May 26, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants