Skip to content

Conversation

saehuihwang
Copy link
Contributor

@debnathshoham debnathshoham added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Sparse Sparse Data Type labels Sep 27, 2021
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @mzeitlin11

@jreback jreback added this to the 1.4 milestone Sep 28, 2021
@mzeitlin11 mzeitlin11 added the Error Reporting Incorrect or improved errors from pandas label Sep 28, 2021
@mzeitlin11 mzeitlin11 merged commit 6b75ed6 into pandas-dev:master Sep 28, 2021
@mzeitlin11
Copy link
Member

Thanks @saehuihwang! As a potential followup if interested, this issue might be present for the Series case too

gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
* BUG: to_coo silently converting non-zero fill values

* fix to_coo benchmark to have 0 fill value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SparseDataFrame.to_coo does not convert the default fill value when is not 0
4 participants