Skip to content

BUG: fix is_named_tuple for objects that are not subclass of tuple #40682 #43253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 4, 2021
Merged

BUG: fix is_named_tuple for objects that are not subclass of tuple #40682 #43253

merged 10 commits into from
Sep 4, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Aug 27, 2021 •
edited
Loading

attack68
attack68 requested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@attack68 attack68 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. minor edit, whatsnew

jreback
jreback requested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls also add a whatsnew note, 1.4 bug fixes I/O (as mostly concerened about sql here)

@jreback jreback added this to the 1.4 milestone Aug 31, 2021
@jreback jreback added Bug IO SQL to_sql, read_sql, read_sql_query labels Aug 31, 2021
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

looks fine. @fangchenli merge when greenish (pls look at the failure, looks not-related)

@jreback jreback merged commit 5e67c78 into pandas-dev:master Sep 4, 2021
@jreback
Copy link
Contributor

jreback commented Sep 4, 2021

thanks @fangchenli

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@fangchenli @feefladder
BUG: fix is_named_tuple for objects that are not subclass of tuple pa…
78e4a81 
…ndas-dev#40682 (pandas-dev#43253)
@fangchenli fangchenli deleted the sqlalchemy-query-named-tuple branch November 18, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attack68 attack68 attack68 requested changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame from sqlalchemy 1.4 Query missing column headers
3 participants
@fangchenli @jreback @attack68