Skip to content

REF: fast_xs avoid object dtype #43203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2021
Merged

REF: fast_xs avoid object dtype #43203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15aa0a6
REF: fast_xs avoid object dtype
jbrockmendel Aug 25, 2021
380d0ec
Merge branch 'master' into ref-fast_xs
jbrockmendel Aug 25, 2021
6470a35
mypy fixup
jbrockmendel Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions pandas/core/internals/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,23 +941,18 @@ def fast_xs(self, loc: int) -> ArrayLike:

n = len(self)
if isinstance(dtype, ExtensionDtype):
# we'll eventually construct an ExtensionArray.
result = np.empty(n, dtype=object)
# TODO: let's just use dtype.empty?
cls = dtype.construct_array_type()
result = cls._empty((n,), dtype=dtype)
else:
result = np.empty(n, dtype=dtype)

result = ensure_wrapped_if_datetimelike(result)
result = ensure_wrapped_if_datetimelike(result)

for blk in self.blocks:
# Such assignment may incorrectly coerce NaT to None
# result[blk.mgr_locs] = blk._slice((slice(None), loc))
for i, rl in enumerate(blk.mgr_locs):
result[rl] = blk.iget((i, loc))

if isinstance(dtype, ExtensionDtype):
result = dtype.construct_array_type()._from_sequence(result, dtype=dtype)

return result

def iget(self, i: int) -> SingleBlockManager:
Expand Down