Fixed all warning.warn messages for space,full-stop etc issues

[Kavya9986]

I have fixed all the warning.warn messages in the entire code base for "Minor typo on warnings #39158" reported issue.

closes #39158

Summary of the changes .
Fix-Tracking-Sheet (2).xlsx

[pep8speaks]

Hello @Kavya9986! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-25 09:55:36 UTC

[debnathshoham]

Hi @Kavya9986 - few tests are failing because the old error messages are used in them. You might want to update the error msgs as well.
You can find more details of the failed tests here.
You may also run the tests locally as mentioned in the doc.

[debnathshoham]

There were two " in the original because the string was split in two lines.
The new string should be "Index names beginning with 'level_' are not round-trippable." (remove the " " from the middle of string).

[Kavya9986]

Hi @Kavya9986 - few tests are failing because the old error messages are used in them. You might want to update the error msgs as well.
You can find more details of the failed tests here.
You may also run the tests locally as mentioned in the doc

Hi !
Thanks. This is very useful . I will try fixing the error messages .

[MarcoGorelli]

Nice - did you run a script to find all of these?

[Kavya9986]

Yes . I ran a script .

[MarcoGorelli]

cool, do you want to share it? perhaps a pre-commit check could be made out of it

[Kavya9986]

List of files changed.
files_changed.txt

Script

#!/bin/bash

while IFS= read -r LINE; do
    echo $LINE
    pre-commit run flake8 --files "$LINE"
done < files_changed.txt

# files_changed.txt are the list of files that where changed since last commit

[MarcoGorelli]

I meant, to find the warnings which needed changing - I don't think pre-commit run flake8 --files will tell you that?

[Kavya9986]

Oh ! Initially I tried automating it fully , but did it partially as I thought return on my time investment would not be justified .

So first I ran this command to find the files and line number where potential fix was required
grep -rn 'warnings.warn(' . | cut -d":" -f1,2 | tr ":" "," > ../fix_tracking_sheet.csv

And then filtered out all the .c files as all the warning messages there where commented .

After which I used this grep -n8 'warnings.warn(' <File Name> to do quick checks on each directory , fixed wherever required .

I'm still trying to use some kind of pattern-matching to automate the whole task :)

I meant, to find the warnings which needed changing - I don't think pre-commit run flake8 --files will tell you that?