Skip to content

Minor typo on warnings #39158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MicaelJarniac opened this issue Jan 13, 2021 · 12 comments · Fixed by #43163
Closed

Minor typo on warnings #39158

MicaelJarniac opened this issue Jan 13, 2021 · 12 comments · Fixed by #43163
Assignees
Labels
Bug good first issue Warnings Warnings that appear or should be added to pandas

Comments

@MicaelJarniac
Copy link
Contributor

warning_message = " ".join([
f"Columns ({warning_names}) have mixed types."
f"Specify dtype option on import or set low_memory=False."
])

"Columns ({warning_names}) have mixed types.Specify dtype option on import or set low_memory=False."
Note the lack of a space after the period on types.Specify. That's because there's no comma separating the strings inside the list, so they get appended while still inside the list, and get passed as a single string to " ".join(...), thus it has nothing to join.
Simply adding the missing comma should fix it.

@MicaelJarniac MicaelJarniac added Docs Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 13, 2021
@MicaelJarniac
Copy link
Contributor Author

take

@MarcoGorelli MarcoGorelli removed the Needs Triage Issue that has not been reviewed by a pandas team member label Jan 17, 2021
@MarcoGorelli MarcoGorelli added this to the Contributions Welcome milestone Jan 17, 2021
@MarcoGorelli MarcoGorelli added Error Reporting Incorrect or improved errors from pandas Warnings Warnings that appear or should be added to pandas and removed Docs Error Reporting Incorrect or improved errors from pandas labels Jan 17, 2021
@MicaelJarniac MicaelJarniac removed their assignment Aug 18, 2021
@Kavya9986
Copy link
Contributor

Hi !
I am new to the open source contribution community .
Can I take this issue ?

@MarcoGorelli
Copy link
Member

go ahead

@Kavya9986
Copy link
Contributor

Just wanted to know if this issue still persists ? Because I think it is already fixed in #39159 .
Am I supposed to find such warning messages in the source code and fix them?

@MarcoGorelli
Copy link
Member

#39159 wasn't merged, so it looks like this is still open

@Kavya9986
Copy link
Contributor

#39159 wasn't merged, so it looks like this is still open

Okay ! Will try fixing this

@karthik200116
Copy link

Hey found this issue still open. Can I take this issue?. I'm new to the open-source community willing to do some useful contributions.

@MarcoGorelli
Copy link
Member

it's being worked on, look up

@Kavya9986
Copy link
Contributor

Hey found this issue still open. Can I take this issue?. I'm new to the open-source community willing to do some useful contributions.

Hey!
I'm working on this issue .

@Kavya9986
Copy link
Contributor

@MarcoGorelli . I have fixed all the warning.warn messages in the entire code .
Here is the pull request Fixed all warning.warn messages for space,full-stop etc issues #43163 .
Could you just review it ?

@Kavya9986
Copy link
Contributor

Gentle ping @MarcoGorelli .
Pull request : #43163

@Kavya9986
Copy link
Contributor

@MarcoGorelli Could you check the pull request ? #43163

fixed flake8
104e786

precommit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug good first issue Warnings Warnings that appear or should be added to pandas
Projects
None yet
5 participants