REF: axis in [..] with _get_axis_number()

[HardevKhandhar]

• xref REF: use _get_axis_number instead of if axis in [...]: #43048
• Refactored test_frame_apply.py
• Created if-else constructs by replacing if axis in [...] by _get_axis_number

[attack68]

lgtm pending green tests. small comment:

you can convert some of the 4-liners into 1 lines by replacing the pattern:

if axis == 0:
    var = value
else:
    var = other_value

with var = value if axis == 0 else other_value.

If it fits on a single line you can even write:

var = value if frame._get_axis_number(axis) == 0 else other_value

[HardevKhandhar]

Done. Please check.
Thank you.

[attack68]

lgtm pending green

[rhshadrach]

This makes it so we aren't testing cases (e.g. passing "index" to apply). I don't think we want to do this in the tests, only in the pandas code itself.

[HardevKhandhar]

Changes reverted to original for test_agg_transform function
Thank you.

[rhshadrach]

Thanks @HardevKhandhar. The same remark applies to your change to the other test here. While the changes you made were certainly of the right form, we just don't want to apply them to the tests. I recommend searching the code in the rest of pandas (outside of tests) and find examples to make this change to.

[HardevKhandhar]

Alright, I have updated the file to the original code & reverted all changes.
Done. Please Check.
Thanks

[rhshadrach]

If we're making no changes, then I think we can close this PR. But just to be sure - I think you're going in the right direction here, just need to make the modification to cases that occur outside of pandas.tests. Once you find some, make the changes similar to what you did here and submit a new PR.

[HardevKhandhar]

Sure, I am closing the PR.
Thanks a lot @rhshadrach :)