REF: use _get_axis_number instead of if axis in [...]:

[attack68]

This PR regards searching the non-test codebase (i.e. don't find code examples in pandas/tests) for examples like the following:

Try to find and replace logic like:

if axis in [0, "index"]:
    ...
elif axis in [1, "columns"]:
    ...
else:
    ...

with the standard codebase method get_axis_number(axis). This is a DataFrame method so often you need use local DataFrame objects to call this method.

It may also be necessary to change axis args in internal methods to consistently accept the same input format compatible with this method, i.e. axis as an integer (0 or 1).

This is an open issue and contributions are welcome to solve individual files in the code. As an example see #43078 or other merged contributions below.

• style.py REF: axis in [...] becomes _get_axis_number(axis) in Styler #43078
• test_label_or_level_utils.py REF: Replacing axis in with _get_axis_number(axis) #43131
• REF: axis in [...] becomes _get_axis_number(axis) in Styler #43121

[rhshadrach]

I think this applies to all code, not just the style, is that right? Or would you like to keep this issue focused on just the styler?

[attack68]

@rhshadrach I don't know. I know that it applies to much of the stuff I wrote in Styler that @jreback pointed out to me. If it applies more broadly can convert this issue into a master tracker and try to locate more examples..

[jreback]

yeah this was mainly for Styler, but its possible we do this elsewhere in the codebase so should clean those up (and ideally have a pre-commit rule but might be non-trivial)

[dhivyadharshin]

Can I work on this issues?

[rhshadrach]

I noticed it in the tests recently, doing some quick searches I'm seeing a few instances in core as well.

[HemanjaliAdini]

hey, can i have this issue?
I'm quite new to this so I might need some guidance

[dhivyadharshin]

Yes you can!

…

On Wed, 18 Aug 2021, 11:32 am Adini Hemanjali, ***@***.***> wrote: hey, can i have this issue? I'm quite new to this so I might need some guidance — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#43048 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARSLAGXRKPDJRYQ2OK4A26TT5NEIRANCNFSM5CGBDK6Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[attack68]

As has been commented here there are likely many places this pattern is present in the code and needs addressing.
The best PRs will be to work on a single file and correct all the offending occurrences within that file. There may be only one item to address or several.
After the PR is approved and merged, we will note it down here as having been addressed.
My example above shows how to do this for a file style.py.

In order to find bits to work on you will have to search for a pattern in the code axis in and then see if you can correct it as per my example.

[dhivyadharshin]

Will do, thanks!

…

On Wed, 18 Aug 2021, 11:53 pm attack68, ***@***.***> wrote: As has been commented here there are likely many places this pattern is present in the code and needs addressing. The best PRs will be to work on a single file and correct all the offending occurrences within that file. There may be only one item to address or several. After the PR is approved and merged, we will note it down here as having been addressed. My example above shows how to do this for a file style.py. In order to find bits to work on you will have to search for a pattern in the code axis in and then see if you can correct it as per my example. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#43048 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARSLAGV2237W7SEON6SXRI3T5P3BNANCNFSM5CGBDK6Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[RohanTrix]

take

[RohanTrix]

@attack68 I have assigned myself to work on this issue, should I move forward with it?

[dhivyadharshin]

Yes, go ahead.

…

On Thu, 19 Aug 2021, 5:41 pm Rohan Sirohia, ***@***.***> wrote: @attack68 <https://github.com/attack68> I have assigned myself to work on this issue, should I move forward with it? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#43048 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARSLAGVJSTRTVF5ZP2PLAFTT5TYF5ANCNFSM5CGBDK6Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[attack68]

Anyone is welcome to work on this issue. This will not be solved by just one PR, there are likely many places and many files where the same work needs to be done. Therefore many people can work on this, simultaneously.

[alli1999]

Hello, could I help with this issue?
This would be my first ever contribution so I could use some guidance

[goyaldhara]

Fixed the issue : #43220

[ghost]

Hey, i want to work towards resolving this issue. Please assign this to me

[ghost]

take

[soni-muskan1234]

Is this instance has to be replaced in test files also or only in generic and style files?

[ForthenchoPacino]

Ok, I'm pretty new to the whole scene, and directly replacing with get_axis_number was presenting with errors, so I tried importing the data frames directly, and that method did not give excess errors, so, I'm almost done

[SARANYA233]

I m first time to this contribution field, I need some guidance to work on this issue. can I?

[attack68]

Please see the revised description of this issue.
You can find code patterns in the generic codebase.
Don't try and fix test files in pandas/tests.

[KiranHipparagi]

I am new to OpenSource Contributions . I want to work on this feature .
@attack68 Can I contribute to this issue ?

[KiranHipparagi]

take

[Tarunssd]

take

[tambibhavika2000]

take

[attack68]

Did a quick search of the codebase and outside of all the test files this seems to have been addressed by all contributions now.