REGR: styler.highlight_min/max did not ignore pd.NA and caused error

[attack68]

• closes BUG: highlight_min and highlight_max do not work with pd.NA #42750
• tests added / passed
• whatsnew entry

[jreback]

i think actually just passing the arg is better here e.g. max(skipna=True) as more readable

[attack68]

i refactored this, pulling the function out, have a relook

[jreback]

thanks @attack68

[jreback]

@meeseeksdev backport 1.3.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 1.3.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 b9edc9a2a3e9cb3251b55e42a87cff2ded2ae6cb

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #42861: REGR: `styler.highlight_min/max` did not ignore `pd.NA` and caused error'

4. Push to a named branch :

git push YOURFORK 1.3.x:auto-backport-of-pr-42861-on-1.3.x

5. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #42861 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

$ git checkout 1.3.x
$ git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 b9edc9a2a3e9cb3251b55e42a87cff2ded2ae6cb

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #42861: REGR: `styler.highlight_min/max` did not ignore `pd.NA` and caused error'

4. Push to a named branch :

git push YOURFORK 1.3.x:auto-backport-of-pr-42861-on-1.3.x

5. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #42861 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

[attack68]

linking #42879