Skip to content

ERR: better error message with invalid argument in sort_values #42358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ERR: better error message with invalid argument in sort_values #42358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3307803
ENH
Jul 3, 2021
d064edc
Update series.py
Jul 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3441,8 +3441,9 @@ def sort_values(
)
ascending = ascending[0]

if not is_bool(ascending):
raise ValueError("ascending must be boolean")

if type(ascending)!=bool:
raise ValueError("ascending should be of type bool")

if na_position not in ["first", "last"]:
raise ValueError(f"invalid na_position: {na_position}")
Expand Down