Skip to content

Backport PR #42160 on branch 1.3.x (PERF: Check identity first before comparing the objects) #42163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Backport PR #42160 on branch 1.3.x (PERF: Check identity first before comparing the objects) #42163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions asv_bench/benchmarks/algos/isin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,3 +325,13 @@ def setup(self, dtype, series_type):

def time_isin(self, dtypes, series_type):
self.series.isin(self.values)


class IsInWithLongTupples:
def setup(self):
t = tuple(range(1000))
self.series = Series([t] * 1000)
self.values = [t]

def time_isin(self):
self.series.isin(self.values)
3 changes: 3 additions & 0 deletions pandas/_libs/src/klib/khash_python.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ int PANDAS_INLINE tupleobject_cmp(PyTupleObject* a, PyTupleObject* b){


int PANDAS_INLINE pyobject_cmp(PyObject* a, PyObject* b) {
if (a == b) {
return 1;
}
if (Py_TYPE(a) == Py_TYPE(b)) {
// special handling for some built-in types which could have NaNs
// as we would like to have them equivalent, but the usual
Expand Down