-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: Add .to_xyz to io docs #41844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add .to_xyz to io docs #41844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks v m @gansel51.
Few comments in line and also:
Can you add a section on LaTeX
and add:
DataFrame.to_latex
and Styler.to_latex
@attack68 For sure. I added the |
@attack68 Added those methods, ready for re-review! |
can you post a render of the page.. i cant generate it or see it here, and just want to check it looks right and has active links? |
@attack68 yeah, here's a screenshot which shows a cross section of the three types of changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This is better with the increased info and links. Would be nice if as a follow on we could get the columns aligning, i.e. by merging the Styler and DataFrame tocs so they dont have different alignment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Just out of curiosity why are some but not all of these namespaced with DataFrame...
@WillAyd The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some CI errors. The docs don't build without errors, I think because the current module is changed in one part of pandas.io.formats.style
and then ExcelWriter
is referenced.
@attack68 The docs didn't build without errors when I first tried pre-PR either, but I switched the current module back for ExcelWriter and it is generating properly. I can't kick off the workflows myself, so we'll need to wait until someone else (@WillAyd?) or you (if able) can do so to see if they pass. See screenshot below for ExcelWriter: |
@attack68 I went ahead and resolved the warnings on the page as well. The page is rendering properly for me with no errors. |
lgtm. can merge on green. |
Thanks @jreback will keep an eye on the checks |
I can switch that, but |
@jreback I just made the change since it is easily revertible. |
actually this is coming from our validate_rst_ checker cc @MarcoGorelli i think there is a way to ignore it |
@jreback cc @MarcoGorelli Any update here? |
moving off 1.3 milestone for now. |
Looks like there's a new
Can use exclude to exclude it from a file "LaTex" should probably be "allowlisted" in the check though - @gansel51 if you wanted to contribute that in a separate PR it would be welcome! |
@jreback @MarcoGorelli @attack68 I removed the deprecated method from the documentation, kicking off a new build could (should?) solve the issue so this PR can merge. I can definitely look into putting LaTeX in the allowlisted next! |
@attack68 I'm not seeing where the checks are failing and not just failing because of a cancellation, can you point me in the right direction? |
in https://github.com/pandas-dev/pandas/pull/41844/checks?check_run_id=2800940727 |
@gansel51 this is ok for 1.3 after its passing. |
isnt this because it should be |
@attack68 @simonjayhawkins Thanks for pointing it out, I was having trouble isolating the error from the logs. Made that change, will keep an eye on the workflow status. |
thanks @gansel51 |
@meeseeksdev backport 1.3.x |
Something went wrong ... Please have a look at my logs. |
Co-authored-by: Griffin Ansel <[email protected]>
Screenshot below for updated docs