Skip to content

DOC/BLD: update README.md, remove setuptools from dependency #41818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 8, 2021
Merged

DOC/BLD: update README.md, remove setuptools from dependency #41818

merged 7 commits into from
Jun 8, 2021

Conversation

fangchenli
Copy link
Member

xref #41815

@jreback
Copy link
Contributor

jreback commented Jun 5, 2021

https://github.com/pandas-dev/pandas/blob/master/setup.cfg#L33 update as well i think

@jreback jreback added Build Library building on various platforms Dependencies Required and optional dependencies labels Jun 5, 2021
@jreback jreback added this to the 1.3 milestone Jun 5, 2021
@fangchenli fangchenli changed the title DOC: update README.md, list setuptools as dependency DOC/BLD: update README.md, list setuptools as dependency Jun 5, 2021
jorisvandenbossche
jorisvandenbossche requested changes Jun 7, 2021
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add it to install_requires, see #41815

README.md Outdated
@@ -100,9 +101,10 @@ pip install pandas
```

## Dependencies
- [Setuptools - A fully-featured, actively-maintained, and stable library designed to facilitate packaging Python projects](https://setuptools.readthedocs.io/en/latest/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the optional dependencies section?

@fangchenli fangchenli changed the title DOC/BLD: update README.md, list setuptools as dependency DOC/BLD: update README.md, remove setuptools from dependency Jun 7, 2021
jorisvandenbossche
jorisvandenbossche reviewed Jun 7, 2021
View reviewed changes
@jreback jreback merged commit 672c468 into pandas-dev:master Jun 8, 2021
@jreback
Copy link
Contributor

jreback commented Jun 8, 2021

thanks @fangchenli

@simonjayhawkins simonjayhawkins mentioned this pull request Jun 8, 2021
Closed
@fangchenli fangchenli mentioned this pull request Jun 14, 2021
Closed
@fangchenli fangchenli deleted the update-readme branch June 18, 2021 02:24
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@fangchenli @JulianWgs
DOC/BLD: update README.md, remove setuptools from dependency (pandas-…
64a72c3 
…dev#41818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche requested changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@fangchenli @jreback @jorisvandenbossche @simonjayhawkins