Bug in loc returning multiindex in wrong oder with duplicated indexer #40987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Bug
Indexing
� Conflicts: � doc/source/whatsnew/v1.3.0.rst
Contributor
|
@phofl can you rebase and will look again |
Member
Author
|
merged master |
jreback
reviewed
May 24, 2021
| ), | ||
| columns=["a"], | ||
| ) | ||
| result = df.loc[(slice(None), indexer), :] |
Contributor
There was a problem hiding this comment.
can you add this as an equivalent test: df_sliced = df.loc[df.index.isin(all_items, level=1), :] should yield the same expected
Member
Author
There was a problem hiding this comment.
Added test, but should not return the same since isin produces an boolean mask, which does not reorder the underlying dataframe. This should be the identity
Contributor
|
thanks @phofl |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ordering, but I am not sure if an indexer with duplicates in this case should return the same as an indexer which is unique with the same elements.