Two missing spaces in argmax, argmin docs #40871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed the missing space that made the documentation render "isthe" instead of "is the". Before the change: - This **isthe** equivalent of the numpy.ndarray method argmax. - This **isthe** equivalent of the numpy.ndarray method argmin. After the change: - This **is the** equivalent of the numpy.ndarray method argmax. - This **is the** equivalent of the numpy.ndarray method argmin. - [ ] closes #xxxx - [ ] tests added / passed - [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them - [ ] whatsnew entry
|
merge on green |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
I fixed the missing space that made the documentation render "isthe" instead of "is the". Before the change: - This **isthe** equivalent of the numpy.ndarray method argmax. - This **isthe** equivalent of the numpy.ndarray method argmin. After the change: - This **is the** equivalent of the numpy.ndarray method argmax. - This **is the** equivalent of the numpy.ndarray method argmin. - [ ] closes #xxxx - [ ] tests added / passed - [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them - [ ] whatsnew entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the missing space that made the documentation render "isthe" instead of "is the".
Before the change:
After the change:
This is the equivalent of the numpy.ndarray method argmax.
This is the equivalent of the numpy.ndarray method argmin.
closes #xxxx
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry