Skip to content

CI: doc failure #40856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2021
Merged

CI: doc failure #40856

merged 2 commits into from
Apr 9, 2021

Conversation

mzeitlin11
Copy link
Member

Attempt to fix doc failure

@mzeitlin11 mzeitlin11 added CI Continuous Integration Docs labels Apr 9, 2021
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -158,6 +158,7 @@ By default the labels are set to the right edge of the window, but a


This can also be applied to datetime-like indices.

.. versionadded:: 1.3
.. ipython:: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it will be needed for sphinx, but might add an empty line between the versionadded and the ipython block as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked ok when I built locally, but agreed might as well keep empty line between directives

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not always clear when sphinx expects one and when not .. ;)
In any case around paragraphs (as you did in the first commit) it's needed.

@jreback jreback added this to the 1.3 milestone Apr 9, 2021
@jreback jreback merged commit 9373dbe into pandas-dev:master Apr 9, 2021
@jreback
Copy link
Contributor

jreback commented Apr 9, 2021

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the docfix branch April 9, 2021 21:55
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants