Skip to content

CLN: tighten cython declarations #40834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 13, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@mzeitlin11
Copy link
Member

@jbrockmendel just fyi in case it's what you're troubleshooting, have run into the annoying ModuleNotFoundError: No module named 'pandas._libs.interval' error before - think it's usually caused by a failure in the build step, not an actual import problem

@jbrockmendel
Copy link
Member Author

think it's usually caused by a failure in the build step, not an actual import problem

you're right. unfortunately the message we re-raise in __init__ obscures any actually-helpful information in the original exception message, hence removing it for the moment

@jreback jreback added this to the 1.3 milestone Apr 13, 2021
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Apr 13, 2021
@jreback jreback merged commit 835b280 into pandas-dev:master Apr 13, 2021
@jbrockmendel jbrockmendel deleted the cln-collect-6 branch April 13, 2021 14:22
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants