Skip to content

BUG: rank treating min int as NaN #40659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 29, 2021
Merged

BUG: rank treating min int as NaN #40659

merged 5 commits into from
Mar 29, 2021

Conversation

mzeitlin11
Copy link
Member

ASV's look unaffected:

before           after         ratio
     [029907c9]       [b45f9193]
     <master>         <bug/rank_datetimelike>
       6.90±0.2ms       6.76±0.6ms     0.98  frame_methods.Rank.time_rank('float')
       2.63±0.3ms       2.39±0.2ms    ~0.91  frame_methods.Rank.time_rank('int')
         45.7±1ms         45.3±1ms     0.99  frame_methods.Rank.time_rank('object')
       2.47±0.2ms       2.22±0.1ms    ~0.90  frame_methods.Rank.time_rank('uint')
      10.8±0.09ms       10.8±0.8ms     1.01  series_methods.Rank.time_rank('float')
       8.10±0.2ms       8.26±0.3ms     1.02  series_methods.Rank.time_rank('int')
         51.3±2ms         51.2±1ms     1.00  series_methods.Rank.time_rank('object')
       8.76±0.6ms       8.30±0.2ms     0.95  series_methods.Rank.time_rank('uint')

@mzeitlin11 mzeitlin11 added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Bug labels Mar 27, 2021
jbrockmendel
jbrockmendel reviewed Mar 28, 2021
View reviewed changes
pandas/_libs/groupby.pyx
@@ -1109,6 +1108,7 @@ def group_rank(float64_t[:, ::1] out,
result = rank_1d(
values=values[:, 0],
labels=labels,
is_datetimelike=is_datetimelike,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep added test for groupby as well

@jreback jreback added this to the 1.3 milestone Mar 29, 2021
@jreback jreback merged commit a59987b into pandas-dev:master Mar 29, 2021
@jreback
Copy link
Contributor

jreback commented Mar 29, 2021

thanks @mzeitlin11

keep em coming on closing older issues!

@mzeitlin11 mzeitlin11 deleted the bug/rank_datetimelike branch March 29, 2021 15:51
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@mzeitlin11 @vladu
BUG: rank treating min int as NaN (pandas-dev#40659)
d45f720
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@mzeitlin11 @JulianWgs
BUG: rank treating min int as NaN (pandas-dev#40659)
47a5e7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Bug
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

rank() for int64 gives NAN for most negative value
3 participants
@mzeitlin11 @jreback @jbrockmendel