STYLE: Extending codespell to pandas/tests Part 2 #40332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
01-vyom
commented
Mar 9, 2021
01-vyom
commented
- xref CI/STYLE extend codespell beyond pandas/core #38802
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
dsaxton
reviewed
Mar 9, 2021
| @@ -433,13 +433,13 @@ def test_setitem_intervals(self): | |||
| assert is_categorical_dtype(df["D"].dtype) | |||
| assert is_interval_dtype(df["D"].cat.categories) | |||
|
|
|||
| # Thes goes through the Series constructor and so get inferred back | |||
| # These goes through the Series constructor and so get inferred back | |||
|
doesn't this have to turn on this in the codespell config? (or is this a precursor) |
Yes @jreback, by removing the exclude from the codespell config, we get 68 file changes so we decided to split those changes into 3 PRs and include the codespell config change in the final PR in-order to pass the pre-commit for all the PRs. More Info here: #40320 |
|
Made all the necessary changes. |
|
Thanks @01-vyom ! |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 11, 2021
* STYLE: Extending codespell to pandas/tests part 2 * DOC: small change in test_setitem.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.