Skip to content

REF: share start_time/end_time between Period/PeriodArray #39279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

One thing that might make this undesirable is that the annotations on this are accurate for Period but not for PeriodArray. Thoughts @simonjayhawkins

@jreback jreback added the Period Period data type label Jan 20, 2021
@jreback jreback added this to the 1.3 milestone Jan 20, 2021
@jreback
Copy link
Contributor

jreback commented Jan 20, 2021

lgtm. can you show the typing issue?

@jbrockmendel
Copy link
Member Author

can you show the typing issue?

start_time and end_time are both annotated as returning Timestamp, but that is only accurate for Period, whereas for PeriodArray the annotation would be DatetimeArray. mypy doesnt pick it up for reasons discussed on last week's call

@jreback
Copy link
Contributor

jreback commented Jan 20, 2021

can you show the typing issue?

start_time and end_time are both annotated as returning Timestamp, but that is only accurate for Period, whereas for PeriodArray the annotation would be DatetimeArray. mypy doesnt pick it up for reasons discussed on last week's call

ok

@jreback jreback merged commit 63f99c2 into pandas-dev:master Jan 21, 2021
@jbrockmendel jbrockmendel deleted the ref-per-share branch January 21, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants