-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Timedelta(td64_out_of_bounds) silently overflowing #38965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jbrockmendel
commented
Jan 5, 2021
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
Updated to avoid using cast_from_unit (which goes through python-space) working on a separate branch to implement tslibs.units that will, among other things, try to share the ndarray/scalar ensure-nanos functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pls merge master (and remove html xfails), they are on master now
pandas/tests/io/test_html.py
Outdated
@@ -130,6 +130,7 @@ def test_to_html_compat(self): | |||
tm.assert_frame_equal(res, df) | |||
|
|||
@tm.network | |||
@pytest.mark.xfail(reason="2021-01-05 HTML layout changed?") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these can be removed
updated + green |