Skip to content

BUG: Timedelta(td64_out_of_bounds) silently overflowing #38965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 6, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added Bug Timedelta Timedelta data type labels Jan 5, 2021
@jbrockmendel
Copy link
Member Author

Updated to avoid using cast_from_unit (which goes through python-space)

working on a separate branch to implement tslibs.units that will, among other things, try to share the ndarray/scalar ensure-nanos functions

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pls merge master (and remove html xfails), they are on master now

@@ -130,6 +130,7 @@ def test_to_html_compat(self):
tm.assert_frame_equal(res, df)

@tm.network
@pytest.mark.xfail(reason="2021-01-05 HTML layout changed?")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be removed

@jreback jreback added this to the 1.3 milestone Jan 6, 2021
@jbrockmendel
Copy link
Member Author

updated + green

@jreback jreback merged commit 8cf3771 into pandas-dev:master Jan 6, 2021
@jbrockmendel jbrockmendel deleted the bug-td-overflow branch January 6, 2021 18:42
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants