BUG/CLN: Minimize number of ResourceWarnings #38168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 30, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
nice! just a small comment
jreback
reviewed
Nov 30, 2020
jreback
reviewed
Nov 30, 2020
pandas/io/parsers.py
Outdated
| self._reader = parsers.TextReader(self.handles.handle, **kwds) | ||
| try: | ||
| self._reader = parsers.TextReader(self.handles.handle, **kwds) | ||
| except Exception as err: |
Contributor
There was a problem hiding this comment.
ahh here's the issue
try:
.....
finally:
self.handle.close()
should do it
Contributor
There was a problem hiding this comment.
we want the original exception to raise as is, but of course close if needed.
Member
Author
There was a problem hiding this comment.
I did that first but unfortunately we might need the reader (and the file handles) if we iteratively read in chunks. We can only close the handle in case of an error.
I think a plain raise would be the best solution? It doesn't seem to add anything new to the traceback.
jreback
approved these changes
Dec 1, 2020
Contributor
|
thanks @twoertwein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI think I got all
ResourceWarnings when running:PYTHONWARNINGS=default pytest pandas/tests/io