Skip to content

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 29, 2020

alternative to #37497, ensures that Series inplace ops are actually inplace whenever possible. The whatsnew is copied verbatim from #37497, the new test is copied with an additional assertion about series._values

@gfyoung gfyoung added Copy / view semantics Regression Functionality that used to work in a prior pandas version labels Oct 30, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit d8c8cbb into pandas-dev:master Oct 30, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1.4 milestone Oct 30, 2020
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 1.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 30, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 d8c8cbb90544b77e5da1daa7274eba7bef3257b9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #37508: REGR: inplace Series op not actually operating inplace'
  1. Push to a named branch :
git push YOURFORK 1.1.x:auto-backport-of-pr-37508-on-1.1.x
  1. Create a PR against branch 1.1.x, I would have named this PR:

"Backport PR #37508 on branch 1.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Oct 30, 2020
simonjayhawkins pushed a commit that referenced this pull request Oct 30, 2020
@jbrockmendel jbrockmendel deleted the bug-36498 branch October 30, 2020 15:00
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Copy / view semantics Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REGR: inplace arithmetic operation on Series no longer updating parent DataFrame
3 participants