Skip to content

BUG: GroupBy().fillna() performance regression #37149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2020
Merged

BUG: GroupBy().fillna() performance regression #37149

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8bc61db
#36757 fix for speed issue
smithto1 Oct 15, 2020
1f8f593
whatsnew
smithto1 Oct 15, 2020
8199ba4
merging master
smithto1 Oct 15, 2020
03bb0be
addressing comments
smithto1 Oct 16, 2020
045e068
Merge remote-tracking branch 'upstream/master' into issue36757
smithto1 Oct 16, 2020
19ddf0d
added asv FillNA
smithto1 Oct 16, 2020
5412aaa
fixing FillNA
smithto1 Oct 16, 2020
bafedb5
black
smithto1 Oct 17, 2020
3272b9b
merging master
smithto1 Oct 17, 2020
8a93e0b
addressing comments
smithto1 Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.1.4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Fixed regressions
Bug fixes
~~~~~~~~~
- Bug causing ``groupby(...).sum()`` and similar to not preserve metadata (:issue:`29442`)
- Bug in :meth:`GroupBy.fillna` that caused a performance regression between 1.0.5 and 1.1.X (:issue:`36757`)

.. ---------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/groupby/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,7 +1196,7 @@ def reset_identity(values):
# when the ax has duplicates
# so we resort to this
# GH 14776, 30667
if ax.has_duplicates:
if ax.has_duplicates and not result.axes[self.axis].equals(ax):
indexer, _ = result.index.get_indexer_non_unique(ax.values)
indexer = algorithms.unique1d(indexer)
result = result.take(indexer, axis=self.axis)
Expand Down