-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI unpin flake8, only run flake8-rst in pre-commit #36722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 10 commits into
pandas-dev:master
from
MarcoGorelli:flake8-rst-pre-commit
Oct 10, 2020
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fd0fd80
only run flake8-rst in pre-commit
MarcoGorelli 4aa3110
update code checks
MarcoGorelli 29c20de
:fire: remove pyflakes from environment.yml
MarcoGorelli a75534b
Merge remote-tracking branch 'upstream/master' into flake8-rst-pre-co…
MarcoGorelli 3473f4b
no need for mirror
MarcoGorelli c3b5a75
language python
MarcoGorelli 12a76e7
Merge remote-tracking branch 'upstream/master' into flake8-rst-pre-co…
MarcoGorelli 9d0891d
yaml formatting
MarcoGorelli 6690f43
Merge remote-tracking branch 'upstream/master' into flake8-rst-pre-co…
MarcoGorelli 0b690c0
Merge remote-tracking branch 'upstream/master' into flake8-rst-pre-co…
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,8 @@ dependencies: | |
# code checks | ||
- black=20.8b1 | ||
- cpplint | ||
- flake8<3.8.0 # temporary pin, GH#34150 | ||
- flake8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can probably remove the pip install of pyflakes>=2.2.0 now. |
||
- flake8-comprehensions>=3.1.0 # used by flake8, linting of unnecessary comprehensions | ||
- flake8-rst>=0.6.0,<=0.7.0 # linting of code blocks in rst files | ||
- isort>=5.2.1 # check that imports are in the right order | ||
- mypy=0.782 | ||
- pre-commit | ||
|
@@ -113,4 +112,3 @@ dependencies: | |
- pip: | ||
- git+https://github.com/pandas-dev/pydata-sphinx-theme.git@master | ||
- git+https://github.com/numpy/numpydoc | ||
- pyflakes>=2.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.