Skip to content

BUG: Fix issue in preserving index name on empty DataFrame #36532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2020
Merged

BUG: Fix issue in preserving index name on empty DataFrame #36532

merged 2 commits into from
Sep 21, 2020

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Sep 21, 2020

@pep8speaks
Copy link

pep8speaks commented Sep 21, 2020 •
edited
Loading

Hello @Dr-Irv! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-21 20:17:46 UTC

@WillAyd WillAyd added the Regression Functionality that used to work in a prior pandas version label Sep 21, 2020
@WillAyd WillAyd added this to the 1.1.3 milestone Sep 21, 2020
@WillAyd WillAyd added Index Related to the Index class or subclasses Indexing Related to indexing on series/frames, not to indexes themselves and removed Index Related to the Index class or subclasses labels Sep 21, 2020
WillAyd
WillAyd approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jorisvandenbossche

@jreback jreback merged commit f59700b into pandas-dev:master Sep 21, 2020
@jreback
Copy link
Contributor

jreback commented Sep 21, 2020

thanks @Dr-Irv

@Dr-Irv Dr-Irv deleted the issue36527 branch September 21, 2020 22:04
@Dr-Irv Dr-Irv mentioned this pull request Sep 22, 2020
Closed
3 tasks
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 1.1.x

jorisvandenbossche
jorisvandenbossche reviewed Sep 22, 2020
View reviewed changes
pandas/tests/indexing/test_partial.py
df["series"] = series
expected = pd.DataFrame(
{"series": [1.23] * 4}, index=pd.RangeIndex(4, name="series_index")
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgor the assert here ;)

(thanks for the PR for the rest!)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #36546

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 22, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 22, 2020
@Dr-Irv @meeseeksmachine
Backport PR pandas-dev#36532: BUG: Fix issue in preserving index name…
5a8a242 
… on empty DataFrame
@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 22, 2020
Merged
jorisvandenbossche pushed a commit that referenced this pull request Sep 22, 2020
@meeseeksmachine @Dr-Irv
Backport PR #36532: BUG: Fix issue in preserving index name on empty …
db4d6be 
…DataFrame (#36545)

Co-authored-by: Irv Lustig <[email protected]>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@Dr-Irv
BUG: Fix issue in preserving index name on empty DataFrame (pandas-de…
b2a0340 
…v#36532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.

BUG: Different behaviour for index after assign dataframe new column by series
5 participants
@Dr-Irv @pep8speaks @jreback @jorisvandenbossche @WillAyd