Skip to content

add a test for loc method; check if a warning raise when replacing a … #36486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 22, 2020
Merged

add a test for loc method; check if a warning raise when replacing a … #36486

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bc745d5
add a test for loc method; check if a warning raise when replacing a …
samilAyoub Sep 19, 2020
e203af0
Clean the code
samilAyoub Sep 19, 2020
d41ac51
using assert_produces_warning instead and rename the method
samilAyoub Sep 19, 2020
176f926
capture rasing instead of warning
samilAyoub Sep 20, 2020
b9f2362
clean the code
samilAyoub Sep 20, 2020
4aa3bb8
remove non standard import and solving linting issues
samilAyoub Sep 20, 2020
c873309
using import
samilAyoub Sep 20, 2020
45a21ba
Sorting imports & matching error message
samilAyoub Sep 21, 2020
1708a9e
Update pandas/tests/indexing/test_loc.py
samilAyoub Sep 21, 2020
8f11f2a
move the test from test_loc to test_chaining_caching.py
samilAyoub Sep 22, 2020
1e09ee1
Merge branch 'add_test_subframe' of https://github.com/samilAyoub/pan…
samilAyoub Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from pandas import DataFrame, Series, Timestamp, date_range
import pandas._testing as tm
from pandas.api.types import is_scalar
import pandas.core.common as com
from pandas.tests.indexing.common import Base


Expand Down Expand Up @@ -1130,3 +1131,17 @@ def test_loc_with_period_index_indexer():
tm.assert_frame_equal(df, df.loc[list(idx)])
tm.assert_frame_equal(df.iloc[0:5], df.loc[idx[0:5]])
tm.assert_frame_equal(df, df.loc[list(idx)])


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put in pandas/tests/indexing/test_chaining_and_caching.py instead with the rest of these tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor Author

@samilAyoub samilAyoub Sep 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a function called test_detect_chained_assignment_warnings that test if chained assignment raise a warning SettingWithCopyWarning in the case of warn option. We need just modify that function to detect also SettingWithCopyError in the case of raise option.

def test_loc_replace_subset_with_subset():
# GH#36424 Should raise a SettingWithCopyError
df1 = pd.DataFrame(
data=np.array([[1, 2, 3], [4, 5, 6], [7, 8, 9]]),
columns=["A", "B", "C"],
index=[0, 0, 1],
)
df2 = df1.copy()
df2[:] = np.nan
msg = r"A value is trying to be set on a copy of a slice from a DataFrame."
with pytest.raises(com.SettingWithCopyError, match=msg):
df2.loc[0]["A"] = df1.loc[0]["A"]