Skip to content

BUG: Don't raise when constructing Series from ordered set #36054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 5, 2020
Merged

BUG: Don't raise when constructing Series from ordered set #36054

merged 10 commits into from
Sep 5, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Sep 1, 2020

This may or may not be a regression, since before the change that caused the error to be raised the output was still wrong (same bug that motivated the initial patch):

In [2]: keys = {'a': 1, 'b': 2}.keys()

In [3]: pd.Series(keys)
Out[3]: 
0    (a, b)
1    (a, b)
dtype: object

@dsaxton dsaxton added Bug Constructors Series/DataFrame/Index/pd.array Constructors labels Sep 1, 2020
@dsaxton dsaxton added this to the 1.1.2 milestone Sep 1, 2020
jbrockmendel
jbrockmendel reviewed Sep 1, 2020
View reviewed changes
jbrockmendel
jbrockmendel reviewed Sep 1, 2020
View reviewed changes
@simonjayhawkins
Copy link
Member

@dsaxton merge conflicts (we should get a Github Action to notify us when this occurs)

jreback
jreback approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can merge on green

@dsaxton dsaxton merged commit c688a0f into pandas-dev:master Sep 5, 2020
@dsaxton dsaxton deleted the series-construction-from-ordered-set branch September 5, 2020 23:13
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 6, 2020
@dsaxton @meeseeksmachine
Backport PR pandas-dev#36054: BUG: Don't raise when constructing Seri…
7a338cc 
…es from ordered set
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 6, 2020
Merged
simonjayhawkins pushed a commit that referenced this pull request Sep 6, 2020
@meeseeksmachine @dsaxton
Backport PR #36054: BUG: Don't raise when constructing Series from or…
a61f1ad 
…dered set (#36162)

Co-authored-by: Daniel Saxton <[email protected]>
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Sep 8, 2020
@dsaxton @jbrockmendel
BUG: Don't raise when constructing Series from ordered set (pandas-de…
c67b707 
…v#36054)
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@dsaxton
BUG: Don't raise when constructing Series from ordered set (pandas-de…
9783e3e 
…v#36054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Constructors Series/DataFrame/Index/pd.array Constructors
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

BUG: Set type check is too strict when creating Series from dict keys
4 participants
@dsaxton @simonjayhawkins @jreback @jbrockmendel