Ensure _group_selection_context is always reset #35572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context managers will resume with an exception if the with block calling them fails. This happening is not an excuse to not clean up.
|
Thanks @eric-wieser for the PR (just adding a note: #35314 uses _group_selection_context more, so if #35314 gets backported, maybe this should also be backported) |
simonjayhawkins
approved these changes
Aug 5, 2020
|
Thanks @eric-wieser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context managers will resume with an exception if the with block calling them fails.
This happening is not an excuse to not clean up.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFound by inspecting the code, not by actually finding a failing example.