Skip to content

DOC: Alligned docstring for ignore_index in append #35056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

DOC: Alligned docstring for ignore_index in append #35056

merged 1 commit into from
Jun 30, 2020

Conversation

erfannariman
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@erfannariman
Copy link
Member Author

erfannariman commented Jun 29, 2020 •
edited
Loading

While working on #34932 I found out that DataFrame.append and Series.append were the only methods with ignore_index where the docstring was different.

@WillAyd WillAyd added the Docs label Jun 29, 2020
@WillAyd WillAyd added this to the 1.1 milestone Jun 29, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 29, 2020

Makes sense - ping on green

@WillAyd WillAyd merged commit c7bc342 into pandas-dev:master Jun 30, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 30, 2020

Thanks @erfannariman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@erfannariman @WillAyd