BUG: clear cache on DataFrame._is_homogeneous_dtype #34937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jun 23, 2020
| @@ -611,7 +611,8 @@ def _is_homogeneous_type(self) -> bool: | |||
| if self._mgr.any_extension_types: | |||
| return len({block.dtype for block in self._mgr.blocks}) == 1 | |||
| else: | |||
| return not self._mgr.is_mixed_type | |||
| # Note: consolidates inplace | |||
There was a problem hiding this comment.
i would rather just push this entire thing to the manager, the frame/series shouldn't really be in charge of this as its accessing internal apis (or at least eventually they will be)
There was a problem hiding this comment.
semi-agree: we shouldnt mix-and-match. But _item_cache pretty much has to be on DataFrame, since that is where the Series objects are created.
jreback
added
API - Consistency
jorisvandenbossche
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff