Skip to content

BUG: indexing regression with datetime index #34917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2020
Merged

BUG: indexing regression with datetime index #34917

merged 5 commits into from
Jun 24, 2020

Conversation

ketanarlulkar
Copy link
Contributor

@ketanarlulkar ketanarlulkar commented Jun 21, 2020 •
edited
Loading

The bug is already fixed on master. I have just added a unit test.

mroeschke
mroeschke reviewed Jun 21, 2020
View reviewed changes
mroeschke
mroeschke reviewed Jun 21, 2020
View reviewed changes
mroeschke
mroeschke reviewed Jun 21, 2020
View reviewed changes
0x0L
0x0L reviewed Jun 22, 2020
View reviewed changes
@pep8speaks
Copy link

pep8speaks commented Jun 22, 2020 •
edited
Loading

Hello @ketanarlulkar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-24 06:31:47 UTC

mroeschke
mroeschke reviewed Jun 22, 2020
View reviewed changes
@ketanarlulkar ketanarlulkar reopened this Jun 23, 2020
mroeschke
mroeschke reviewed Jun 23, 2020
View reviewed changes
@jreback jreback changed the title Added unit test for bug mentioned in issue-34860. BUG: indexing regression with datetime index Jun 23, 2020
@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite Datetime Datetime data dtype labels Jun 23, 2020
@jreback jreback added this to the 1.1 milestone Jun 23, 2020
jreback
jreback requested changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be with other partial indexing tests: pandas/tests/indexing/test_partial.py

@jreback jreback merged commit 6a6faf5 into pandas-dev:master Jun 24, 2020
@jreback
Copy link
Contributor

jreback commented Jun 24, 2020

thanks @ketanarlulkar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@jreback jreback jreback approved these changes

+1 more reviewer

@0x0L 0x0L 0x0L approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Datetime Datetime data dtype Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: indexing regression with datetime index
5 participants
@ketanarlulkar @pep8speaks @jreback @0x0L @mroeschke