Skip to content

DOC: Fixed table formatting in box plot section #34885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pvanhauw
Copy link
Contributor

[DOC]fixed table formatting in the box plot section keeing simple rst table format

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

[DOC]fixed table formatting in the box plot section keeing simple rst table format
@MarcoGorelli MarcoGorelli self-requested a review June 20, 2020 10:44
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pvanhauw , it look better like this!

@@ -444,8 +444,7 @@ keyword, will affect the output type as well:

================ ======= ==========================
``return_type=`` Faceted Output type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the = - I know it was there originally, but I don't think it really makes sense

@MarcoGorelli
Copy link
Member

Also @pvanhauw can you update the title of the PR to [DOC]fixed table formatting in the box plot section?

@pvanhauw
Copy link
Contributor Author

Also @pvanhauw can you update the title of the PR to [DOC]fixed table formatting in the box plot section?

I just did

@jorisvandenbossche
Copy link
Member

@pvanhauw it seems the PR title rename didn't come through

@pvanhauw pvanhauw changed the title pydata amsterdam 2020 [DOC]fixed table formatting in box plot section Jun 20, 2020
@jorisvandenbossche jorisvandenbossche changed the title [DOC]fixed table formatting in box plot section DOC: fixed table formatting in box plot section Jun 20, 2020
@pvanhauw pvanhauw changed the title DOC: fixed table formatting in box plot section DOC: Fixed table formatting in box plot section Jun 20, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jorisvandenbossche jorisvandenbossche merged commit 502052a into pandas-dev:master Jun 20, 2020
@pvanhauw
Copy link
Contributor Author

thanks for helping me on my first PR !

@pvanhauw pvanhauw deleted the doc-viz-table-reformatting branch June 20, 2020 12:05
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Jun 20, 2020
wesbarnett pushed a commit to wesbarnett/pandas that referenced this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants