Skip to content

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jun 15, 2020

@jreback jreback added the IO JSON read_json, to_json, json_normalize label Jun 15, 2020
@fangchenli
Copy link
Member Author

The Travis CI check for python3.9-dev failed. Not sure what's going on.

@fangchenli fangchenli requested review from jreback and WillAyd June 17, 2020 21:03
@WillAyd
Copy link
Member

WillAyd commented Jun 17, 2020

I think looks good. Can you add a whatsnew note for v1.1?

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm @jreback

@jreback jreback added this to the 1.1 milestone Jun 25, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. if you can add a whatsnew note in 1.1, bug fixes I/O section. ping on green.

@fangchenli fangchenli force-pushed the readjson-lines-chunks branch from 0a517f9 to 6cc04ee Compare June 27, 2020 06:45
@fangchenli fangchenli requested a review from jreback June 27, 2020 16:43
@WillAyd WillAyd merged commit 6598e39 into pandas-dev:master Jun 29, 2020
@WillAyd
Copy link
Member

WillAyd commented Jun 29, 2020

Thanks @VirosaLi

@fangchenli fangchenli deleted the readjson-lines-chunks branch June 29, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO JSON read_json, to_json, json_normalize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_json different behaviour when file is os path or file url
3 participants