-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
INT: take DateOffset out of the inheritance tree for BaseOffset subclasses #34147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 11 commits into
pandas-dev:master
from
jbrockmendel:ref-liboffsets-inits
May 13, 2020
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2338101
REF: move apply_wraps up into liboffstes
jbrockmendel bde1150
dummy commit to force CI
jbrockmendel ea559e2
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel cef38e2
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 8133acb
CI: Setup 3.9 Travis Build (#33505)
alimcmaster1 cc8cfda
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 7081935
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 2047a67
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 7da95ce
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 895264a
INT: take DateOffset out of the inheritance tree for BaseOffset subcl…
jbrockmendel 72a6429
mypy fixups
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonjayhawkins is this going to mess up annotations elsewhere we annotate something as a DateOffset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy is a static checker, so IIUC mypy doesn't execute the code in __instancecheck__ and __subclasscheck__. Therefore, mypy has no way of knowing that BaseOffset subclass pretend to be DateOffset subclasses.
This is probably a use case for Protocol. i.e. structural typing instead of nominal typing.