INT: take DateOffset out of the inheritance tree for BaseOffset subclasses #34147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Python 3.9 build * Python 3.9 build * Python 3.9 build * Python 3.9 build * Update build39.sh minor comments * Update .travis.yml Skip clipboard tests * Python 3.9 tests * Dummy commit * Use numpy master manylinux wheel * use scipy nightly wheels * Build numpy from source
…f-liboffsets-inits
…f-liboffsets-inits
…f-liboffsets-inits
…f-liboffsets-inits
jbrockmendel
commented
Jun 1, 2020
| return isinstance(obj, BaseOffset) | ||
|
|
||
| @classmethod | ||
| def __subclasscheck__(cls, obj) -> bool: |
There was a problem hiding this comment.
@simonjayhawkins is this going to mess up annotations elsewhere we annotate something as a DateOffset?
There was a problem hiding this comment.
mypy is a static checker, so IIUC mypy doesn't execute the code in __instancecheck__ and __subclasscheck__. Therefore, mypy has no way of knowing that BaseOffset subclass pretend to be DateOffset subclasses.
This is probably a use case for Protocol. i.e. structural typing instead of nominal typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
__instancecheck__override to keep isinstance checks working.This will allow us to start moving other BaseOffset subclasses up into liboffsets without having to get DateOffset (which will be one of the trickiest) first.