MAINT: Clarify supported Stata dta versions #34116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if a what's new is needed here. |
|
lgtm. yeah I would add a whatsnew indicating which versions are being removed for unreliability :-> ping on green. |
|
are these versions listed in the doc-string? |
bashtage
force-pushed
the
stata-old-compat
branch
from
bb8e6e6 to
6e62b3a
Compare
|
@jreback I have gone through and removed any references to the unsupported versions. There were none in docstrings; they were only in a few places that compared the version read to a minimum version. |
Test against old Stata versions and remove text indicating support for versions which do not work reliably closes pandas-dev#26667
bashtage
force-pushed
the
stata-old-compat
branch
from
6e62b3a to
665621c
Compare
|
thanks @bashtage |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test against old Stata versions and remove text indicating support
for versions which do not work reliably
closes #26667
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff