REF: use _wrap_joined_index in PeriodIndex.join #33736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+593
to
+597
| if is_period_dtype(self.dtype): | ||
| freq = self.freq | ||
| else: | ||
| self = cast(DatetimeTimedeltaMixin, self) | ||
| freq = self.freq if self._can_fast_union(other) else None |
There was a problem hiding this comment.
to avoid this pattern in the base class, could _can_fast_union be overridden in PeriodIndex to always return True.
There was a problem hiding this comment.
on second thoughts perhaps put in DatetimeIndexOpsMixin and then it's overridden in DatetimeTimedeltaMixin and the cast is not necessary.
There was a problem hiding this comment.
i considered this, but im planning to implement an actual _can_fast_union for PeriodIndex before long
simonjayhawkins
added
Index
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodIndex defines _apply_meta, but that is made unnecessary by implementing _wrap_joined_index correctly.