Skip to content

REF: avoid internals in tshift #33056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2020
Merged

REF: avoid internals in tshift #33056

merged 2 commits into from
Mar 27, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added Clean Internals Related to non-user accessible pandas implementation labels Mar 27, 2020
@jreback jreback added this to the 1.1 milestone Mar 27, 2020
jreback
jreback reviewed Mar 27, 2020
View reviewed changes
pandas/core/generic.py

return self._constructor(new_data).__finalize__(self)
result = self.copy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are very inconsistent on how calling .set_axis in generic.py, e.g. whether using inplace True/False & also _reset_cached_item.

ok here, but think this would be good to be consistent about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah, #31784 has got me looking at the caching thing now. is this just to avoid the perf overhead of creating Series objects?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it may be possible to rip this out as it causes a number of bugs, but would have to see perf impacts.

@jreback jreback merged commit b6cb1a4 into pandas-dev:master Mar 27, 2020
@jreback
Copy link
Contributor

jreback commented Mar 27, 2020

merging, but if you can centrailze the ways we reconstruct objects would be great

@jbrockmendel
Copy link
Member Author

but if you can centrailze the ways we reconstruct objects would be great

would you believe im working right now on a branch called "cln-update_inplace"

@jbrockmendel jbrockmendel deleted the tshift branch March 27, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Clean Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback