REF: implement _with_freq, use _from_sequence less #32849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 21, 2020
| @@ -396,6 +396,34 @@ def floor(self, freq, ambiguous="raise", nonexistent="raise"): | |||
| def ceil(self, freq, ambiguous="raise", nonexistent="raise"): | |||
| return self._round(freq, RoundTo.PLUS_INFTY, ambiguous, nonexistent) | |||
|
|
|||
| def _with_freq(self, freq): | |||
There was a problem hiding this comment.
Optional[Union[Dateoffset, str]]
There was a problem hiding this comment.
returns Union[DTA,TDI,PA] (but I think we have a type for this)
There was a problem hiding this comment.
just tried this and it looks like its going to turn into a yak-shaving event, prefer to do that separately
jreback
approved these changes
Mar 22, 2020
|
thanks |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes method-chaining a little bit nicer.
Moving away from using _from_sequence and towards using the constructors where feasible. This will make it easier to stricten what we accept in these _from_sequence methods.
We also should be inferring freq less in arithmetic methods, but that is a behavior change that will be done separately.