(wip) BUG: groupby with sort=False create buggy multiindex #32506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Mar 7, 2020
MarcoGorelli
force-pushed
the
issue-32259
branch
from
95921b9 to
27e9dc6
Compare
MarcoGorelli
commented
Mar 8, 2020
| # GH 17537 | ||
| grouped = mframe.groupby(level=0, sort=sort) | ||
| exp_labels = np.array(labels, np.intp) | ||
| exp_labels = np.array([2, 2, 2, 0, 0, 1, 1, 3, 3, 3], np.intp) |
There was a problem hiding this comment.
Am deliberately changing the codes, so IMO it's right to change this test as well
MarcoGorelli
commented
Mar 8, 2020
Comment on lines
+283
to
+285
| if len(all_codes) > 1 or not isinstance( | ||
| ping.grouper, (Categorical, CategoricalIndex, BinGrouper) | ||
| ): |
There was a problem hiding this comment.
I feel really uneasy about this special-casing, just seeing if it works
|
This is a tough one, I'll come back to it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffStill messy, just running this through the test suite as my laptop's not great (but please let me know if such behaviour is unwelcome and I won't do it again)
pandas/tests/groupby/test_timegrouper.py
pandas/tests/groupby/test_grouping.py
pandas/tests/groupby/test_categorical.py
pandas/tests/groupby/test_groupby.py
pandas/tests/test_multilevel.py