Skip to content

CLN: imports in pandas/io/excel/_base.py #32481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2020
Merged

CLN: imports in pandas/io/excel/_base.py #32481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a99c27a
CLN: imports in pandas/io/excel/_base.py
Mar 6, 2020
815705f
Merge remote-tracking branch 'upstream/master' into CLN-IMPORTS-io-ex…
Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions pandas/io/excel/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import abc
from datetime import date, datetime, timedelta
import datetime
from io import BytesIO
import os
from textwrap import fill
Expand Down Expand Up @@ -28,7 +28,6 @@
_pop_header_name,
get_writer,
)
from pandas.io.formats.printing import pprint_thing
from pandas.io.parsers import TextParser

_read_excel_doc = (
Expand Down Expand Up @@ -742,11 +741,11 @@ def _value_with_fmt(self, val):
val = float(val)
elif is_bool(val):
val = bool(val)
elif isinstance(val, datetime):
elif isinstance(val, datetime.datetime):
fmt = self.datetime_format
elif isinstance(val, date):
elif isinstance(val, datetime.date):
fmt = self.date_format
elif isinstance(val, timedelta):
elif isinstance(val, datetime.timedelta):
val = val.total_seconds() / float(86400)
fmt = "0"
else:
Expand All @@ -763,9 +762,7 @@ def check_extension(cls, ext):
if ext.startswith("."):
ext = ext[1:]
if not any(ext in extension for extension in cls.supported_extensions):
msg = "Invalid extension for engine"
f"'{pprint_thing(cls.engine)}': '{pprint_thing(ext)}'"
raise ValueError(msg)
raise ValueError(f"Invalid extension for engine '{cls.engine}': '{ext}'")
else:
return True

Expand Down